fix(lock): sanitize WAYLAND_DISPLAY in lockfile path - #197
Open
re2zero wants to merge 1 commit into
Open
Conversation
When WAYLAND_DISPLAY contains a slash (e.g. wl/wayland-1), the lockfile path would include a subdirectory component that may not exist, causing open() to fail. Replace '/' with '-' in WAYLAND_DISPLAY before constructing the lockfile path. Fixes emersion#188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WAYLAND_DISPLAYby replacing/with-before constructing the lockfile pathProblem
When
WAYLAND_DISPLAYcontains a slash (e.g.wl/wayland-1), the lockfile path becomes$XDG_RUNTIME_DIR/slurp-wl/wayland-1.lock. Thewl/subdirectory may not exist, causingopen()to fail with "failed to open lock file".Fix
Replace
/with-inWAYLAND_DISPLAYbefore constructing the path, sowl/wayland-1becomeswl-wayland-1, producing a valid flat path$XDG_RUNTIME_DIR/slurp-wl-wayland-1.lock.Changes
lock.c/with-Fixes #188